Russian Localization & Cyrillic Fixes#125
Open
Neeo1504 wants to merge 13 commits intoDaleHuntGB:mainfrom
Open
Conversation
Add file with russian localization (ver. 1.0)
Added connection to a file with Russian localization
If maxChar = 0, then show full spellname
Increased the spell name length setting to 64 characters
Update CastBar.lua
Update GUI.lua
lorientalas
reviewed
Apr 9, 2026
| spellName_MaxCharactersSlider:SetLabel(LL("Max Characters")) | ||
| spellName_MaxCharactersSlider:SetValue(BCDM.db.profile.CastBar.Text.SpellName.MaxCharacters) | ||
| spellName_MaxCharactersSlider:SetSliderValues(0, 32, 1) | ||
| spellName_MaxCharactersSlider:SetSliderValues(0, 64, 1) |
There was a problem hiding this comment.
maybe it's better to fix sub at CastBar.lua:13
local function GetDisplayCastText(text, maxChars)
if not text then return "" end
if BCDM:IsSecretValue(text) then
return text
end
if strlenutf8(text) > maxChars then
return string.utf8sub(text, 1, maxChars) .. "..."
end
return text
end
?
Author
There was a problem hiding this comment.
Hello!
Thanks a ton for the great catch! You're absolutely right — using plain string.sub on Russian text is just asking for trouble. Your solution with strlenutf8 and string.utf8sub is way cleaner and actually correct. I really appreciate you taking the time to point that out.
Here's the final version of the function I'm using now:
lua
local function GetDisplayCastText(text, maxChars)
if not text then return "" end
if BCDM:IsSecretValue(text) then
return text
end
if maxChars == 0 then
return text
end
if strlenutf8(text) > maxChars then
return string.utf8sub(text, 1, maxChars) .. "..."
end
return text
end
It keeps the "no limit" behavior when maxChars == 0 (so people can still see full spell names if they want), and now truncates safely with an ellipsis. The slider still goes up to 64, but now it actually works as expected for any language.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main changes
Full Russian translation
Locales/ruRU.luacontaining all localized strings for the addon’s interface, including general settings, power colors, spell/item management, profiles, and support messages.Cyrillic font support
GUI.luato apply the user-selected font (BCDM.Media.Font) to all relevant UI elements (headings, labels, interactive labels, info tags).SetFontForAceWidgetto unify font handling across AceGUI widgets.Spell name truncation fix
GUI.lua).CastBar.luaso that setting "Max Characters" to 0 now displays the full spell name instead of an empty string, which is especially useful for longer Russian spell names.Additional missing translations
UI consistency fixes
LL()calls where they were missing (e.g., in glow type dropdown, anchor points).SetFontForAceWidgetcalls for heading widgets in the Profile section that caused layout corruption.All changes have been tested with the Russian game client and ensure that every visible part of the addon is properly translated and displayed with the correct fonts.